Feature: Add IPv6 support #34
Conversation
pkg/factory/config.go
Outdated
| RegisterIPv4 string `yaml:"registerIPv4,omitempty" valid:"host,optional"` // IP that is registered at NRF. | ||
| RegisterIP string `yaml:"registerIP,omitempty" valid:"host,optional"` // IP that is registered at NRF. | ||
| BindingIPv4 string `yaml:"bindingIPv4,omitempty" valid:"host,optional"` // IP used to run the server in the node. | ||
| BindingIP string `yaml:"bindingIP,omitempty" valid:"host,optional"` // IP used to run the server in the node. |
There was a problem hiding this comment.
Do we need two variables that stand for the same thing?
Or using RegisterIP and BindingIP only?
There was a problem hiding this comment.
RegisterIP/BindingIP both works with IPv6 and Ipv4
But, if we remove RegisterIPv4/BindingIPv4, we will have to adapt every configuration files that use it
This is why the solution of this MR is to keep RegisterIPv4/BindingIPv4 fields, to use them as a the fallback of RegisterIP/BindingIP
| ueauService := (*udmInstance.NfServices)[0] | ||
| ueauEndPoint := (*ueauService.IpEndPoints)[0] | ||
| port := uint16(ueauEndPoint.Port) | ||
| if len(udmInstance.Ipv6Addresses) > 0 && udmInstance.NfServices != nil { |
There was a problem hiding this comment.
UDM should register with IPv6 for this code to work.
I think this change can be done in another PR or wait for UDM to have a PR ready.
There was a problem hiding this comment.
That a work in progress, I begin to work on the IPv6 support for UDM adjivas/udm#1
I will open this PR to the Free5gc's UDM later
Hello,
This PR adds the RegisterIP/BindingIP fields, we can set them with IPv4 or IPv6 values
For not introduce any breaking changes, the RegisterIPv4/BindingIPv4 are the fall back of the RegisterIP/BindingIP fields.
It's adds a validation rule to avoid missing or duplicate field.
I test this PR with this fix of the Free5gs's Nrf to have this valid results:
